Add shutdown API support#530
Merged
Merged
Conversation
artursouza
reviewed
Mar 31, 2021
artursouza
previously approved these changes
Apr 3, 2021
| public Mono<Void> shutdown() { | ||
| String[] pathSegments = new String[]{ DaprHttp.API_VERSION, "shutdown" }; | ||
| return Mono.subscriberContext().flatMap( | ||
| context -> client.invokeApi(DaprHttp.HttpMethods.GET.name(), pathSegments, |
Contributor
There was a problem hiding this comment.
We will update this to POST. GET will still be supported for backwards compatibility but POST is the recommended way. Charlie has a PR for that in runtime.
Codecov Report
@@ Coverage Diff @@
## master #530 +/- ##
============================================
+ Coverage 80.46% 80.65% +0.19%
- Complexity 975 982 +7
============================================
Files 88 88
Lines 3015 3024 +9
Branches 331 331
============================================
+ Hits 2426 2439 +13
+ Misses 423 420 -3
+ Partials 166 165 -1
Continue to review full report at Codecov.
|
artursouza
approved these changes
Apr 7, 2021
fackee
pushed a commit
to fackee/java-sdk
that referenced
this pull request
Mar 28, 2022
* Add shutdown API support dapr#529 * Utilize POST instead of GET for shutdown API Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the shutdown API.
Issue reference
This PR will close: #529
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: